Fix Redis limiter #885
Merged
Fix Redis limiter #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
=======================================
Coverage 85.80% 85.80%
=======================================
Files 190 190
Lines 14600 14600
=======================================
Hits 12527 12527
Misses 2073 2073 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cotanoine
approved these changes
Oct 24, 2025
Luhmos
approved these changes
Oct 24, 2025
NakoGH
approved these changes
Oct 24, 2025
Marc-Andrieu
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
When using multiple IPs in FORWARDED_ALLOW_IPS variable, request.client.host can be something else than an IP address string and will be wrongly parsed by Redis, implying an error and refusing the connection.
Changes Made
Type of Change
🐛 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
🔧 Infra CI/CD (changes to configs of workflows)
💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
😶🌫️ No impact for the end-users
Impact & Scope
Core functionality changes
Single module changes
Multiple modules changes
Database migrations required
Other:
Testing
1. Tested this locally
2. Added/modified tests that pass the CI
3. Tested in a pre-prod
0. Untestable (exceptionally), will be tested in prod directly
Error condition are uncertain and can't be reproduced
Documentation
Updated the docs accordingly :
"Docstrings#Inline commentsNo documentation needed